[PATCH] D123231: [StructurizeCFG] Improve basic block ordering

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

I'm being picky about the description because I'd really like to understand it clearly before reading the code.

> This patch reduces the of Phi values needed

"the //number// of Phi values"

> This is problem
> especially with ASAN, which adds early exits to unreachable
> blocks for each instrumented check in the loop.

I don't understand what "unreachable" refers to here.

> In specific cases, this patch reduces the number of values needed
> after loop by moving the exit block to the loop.

I think "//into// the loop" would be clearer if that's what you mean.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123231/new/

https://reviews.llvm.org/D123231