[PATCH] D122672: [CodeGen][ARM] Enable Swing Module Scheduling for ARM

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:2715
+  SmallSet<SUnit *, 8> DoNotPipeline;
+  DoNotPipeline.clear();
+  SmallVector<SUnit *, 8> Worklist;
----------------
I don't think you need to clear this if it has just been created


================
Comment at: llvm/lib/CodeGen/ModuloSchedule.cpp:318
+  if (OrigBB != TBB)
+    TII->insertBranch(*KernelBB, EpilogStart, KernelBB, Cond, DebugLoc());
+  else
----------------
Do you have test cases for these different fixes? I see one, but it would be good to make sure we are testing various situations if they can come up.


================
Comment at: llvm/test/CodeGen/Thumb2/swp-fixedii.mir:5-6
+--- |
+  ; ModuleID = 'swp-fixedii.ll'
+  source_filename = "swp-fixedii.ll"
+  target datalayout = "e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
----------------
You can probably remove this, maybe `hidden`, `local_unnamed_addr` and sometimes the attributes too.


================
Comment at: llvm/test/CodeGen/Thumb2/swp-fixedii.mir:54
+exposesReturnsTwice: false
+legalized:       false
+regBankSelected: false
----------------
I usually delete some of this that isn't needed. Like the FrameInfo and empty stacks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122672/new/

https://reviews.llvm.org/D122672