[PATCH] D123512: [MachineCombiner]: Avoid including transient instructions in latency calculation

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 00:14:32 PDT 2022


dmgreen added a comment.

Are you sure this code is doing what it is intended to be doing? If it is adding the latencies (depths) between operands of inserted instructions and their defs, and we say that the latency of transient instructions are ignored, that what adds the latency between the last instruction and whatever will end up using it?

The scheduling info this is using on it's own doesn't suggest this should be changing `mul;sub` to `neg;mla`: https://godbolt.org/z/G1WTW5P9x


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123512/new/

https://reviews.llvm.org/D123512



More information about the llvm-commits mailing list