[PATCH] D123563: GlobalISel: Use correct bool extension for select mask

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:7278-7279
+      // boolean's context.
+      MaskElt = MIRBuilder.buildBoolExt(DstTy.getElementType(),
+                                        MaskElt, false).getReg(0);
+    }
----------------
Actually this whole promotion is wrong. There's no meaningful relationship between the bitwidth of the result type and the compare type. This also doesn't account for the original scalar being promoted


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123563/new/

https://reviews.llvm.org/D123563