[PATCH] D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines

Pretty-box via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 19:26:19 PDT 2022


Pretty-box added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/ssub_sat.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc < %s -mtriple=riscv32 -mattr=+m | FileCheck %s --check-prefix=RV32I
-; RUN: llc < %s -mtriple=riscv64 -mattr=+m | FileCheck %s --check-prefix=RV64I
-; RUN: llc < %s -mtriple=riscv32 -mattr=+m,+zbb | FileCheck %s --check-prefixes=RV32IZbb,RV32IZbbNOZbt
-; RUN: llc < %s -mtriple=riscv64 -mattr=+m,+zbb | FileCheck %s --check-prefixes=RV64IZbb,RV64IZbbNOZbt
+; RUN: llc < %s -mtriple=riscv32 -mattr=+m | FileCheck %s --check-prefixes=RV32,RV32I
+; RUN: llc < %s -mtriple=riscv64 -mattr=+m | FileCheck %s --check-prefixes=RV64,RV64I
----------------
craig.topper wrote:
> The RV32 prefix is confusing because zbt command lines don't use it. So it's really RV32NoZbt?
yes, I agree with you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123176/new/

https://reviews.llvm.org/D123176



More information about the llvm-commits mailing list