[PATCH] D123368: [X86] Remove different address space check in isNoopAddrSpaceCast

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D123368#3441750 <https://reviews.llvm.org/D123368#3441750>, @wenju wrote:

> isNoopPtrIntCastPair in lib/Transforms/Scalar/InferAddressSpaces.cpp calls isNoopAddrSpaceCast, but the two arguments might be the same. I notice isNoopAddrSpaceCast in other targets don't have such assert, so I remove this assert in X86 target.
> Do you think we should check address spaces are not the same prior to isNoopAddrSpaceCast callsite in isNoopPtrIntCastPair?

So you're claiming InferAddressSpaces asserts for x86? Can you add a test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123368/new/

https://reviews.llvm.org/D123368