[PATCH] D123460: [OpenMP] Make generating offloading entries more generic
Joseph Huber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 15:21:05 PDT 2022
jhuber6 added a comment.
In D123460#3443925 <https://reviews.llvm.org/D123460#3443925>, @tianshilei1992 wrote:
> If we'd like it to be used by CUDA or other programming models, `llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp` is not a good place. Other than that, the patch looks good to me.
I couldn't think of a better place to put this. Using it outside of OpenMP just requires initializing the OpenMP types so it's not a huge burden. I also want to change the names from `omp_offloading` so it's more generic but figured I wouldn't pollute the patch with those test changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123460/new/
https://reviews.llvm.org/D123460
More information about the llvm-commits
mailing list