[PATCH] D123531: [GlobalsModRef][FIX] Ensure we honor synchronizing effects of intrinsics

Mon Apr 11 14:53:03 PDT 2022

jdoerfert added a comment.

In D123531#3443851 <https://reviews.llvm.org/D123531#3443851>, @efriedma wrote:

> The check looks right now.

Great. I'll get on the remaining issues.

> 1. There's another use of isIntrinsic() a few lines earlier; do we need to fix that?

We do. I will make a helper and use it both times.

> 2. Is this going to have the same issue as D115302 <https://reviews.llvm.org/D115302> where there are a bunch of intrinsics that currently don't have the expected markings?

People will need to annotate their intrinsics or use DefaultIntrinsics at some point. The latter have nosync and nocallback.

> 3. Missing testcases.

working on it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123531/new/

https://reviews.llvm.org/D123531