[PATCH] D123531: [GlobalsModRef][FIX] Ensure we honor synchronizing effects of intrinsics

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 13:59:27 PDT 2022


efriedma added a comment.

The check looks right now.

Remaining concerns:

1. There's another use of isIntrinsic() a few lines earlier; do we need to fix that?
2. Is this going to have the same issue as D115302 <https://reviews.llvm.org/D115302> where there are a bunch of intrinsics that currently don't have the expected markings?
3. Missing testcases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123531/new/

https://reviews.llvm.org/D123531



More information about the llvm-commits mailing list