[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals
Mitch Phillips via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 13:33:46 PDT 2022
hctim added a comment.
In D123538#3443755 <https://reviews.llvm.org/D123538#3443755>, @tschuett wrote:
> I do not want to bother you at all:
> https://llvm.org/docs/ProgrammersManual.html#map
Is there a better data structure you'd recommend? I picked the map based on the following:
> std::map is most useful when your keys or values are very large
given the 10.5k `DW_TAG_variable`s in bionic `libc.so` and the quote from DenseMap:
> it will waste a lot of space if your keys or values are large
Am I misreading the above sentence to mean "if the count of keys is huge", and the intended meaning is "if sizeof(key) is huge"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123538/new/
https://reviews.llvm.org/D123538
More information about the llvm-commits
mailing list