[PATCH] D123531: [GlobalsModRef][FIX] Ensure we honor synchronizing effects of intrinsics

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D123531#3443564 <https://reviews.llvm.org/D123531#3443564>, @efriedma wrote:

> Did you mean to drop the `!F->isIntrinsic()` check?  I mean, I guess you could replace it with `!F->isDeclaration()`, but I think you need some protection against optnone function definitions, since we don't analyze their bodies.

I dropped it on purpose but we might need more checks.
I don't believe intrinsics are special, or at least should be.

To me it looked like optnone is treated like a declaration already. Is that wrong? If it is not, I don't think we need the declaration check but at the end of the day we can be conservative in the presence of optnone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123531/new/

https://reviews.llvm.org/D123531