[PATCH] D122106: [BOLT] Fix dynamic relocation offset for constant islands

[Rafael Auler via Phabricator via llvm-commits]

rafauler added a comment.

I suspect the regression in time might be because we are emitting too many labels unnecessarily. We are emitting a label for every relocation, right? Maybe the best approach would be to create a special class for DynamicRelocation and only that will have extra fields to store a label, and then change our emitter to emit a label only for those objects (as opposed to every static reloc), and then later in updateOutputValues fetch that label? I think this would avoid the memory/time regression, unless I'm missing something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122106/new/

https://reviews.llvm.org/D122106