[PATCH] D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

Looks like the other comments have been addressed. I will stamp it at EOD today if no one objects



================
Comment at: lld/include/lld/Common/CommonLinkerContext.h:84
+
+inline llvm::StringSaver &saverUnsafe() { return context().saver; }
+
----------------
oontvoo wrote:
> aganea wrote:
> > I agree that those "unsafe" functions might not be needed. The same applies to the two "perThread*" functions above. Can we just go through `saver()` and `bAlloc()`? Do we really want application code to explicitly choose either per-thread allocation pool or the global allocation pool?
> @MaskRay : any concern with removing this option? IIRC, you would like this option for performance reason.
let's remove it for now, folks can always add it back if they want to use it

let's drop the "perThread" prefixes too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122922/new/

https://reviews.llvm.org/D122922