[PATCH] D112330: [AArch64] Async unwind - function epilogues

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/framelayout-sve.mir:266
 # CHECK-NEXT: $sp = frame-destroy ADDVL_XXI $sp, 3
+# CHECK-NEXT: frame-destroy CFI_INSTRUCTION
 # CHECK-NEXT: $sp = frame-destroy ADDXri $sp, 16, 0
----------------
chill wrote:
> MaskRay wrote:
> > Specify the operands of CFI_INSTRUCTION
> Looks redundant to me. The operands are evident from the `ASM` and `UNWINDINFO` checks.
SVE has quite complex code paths in the implementation, so it's good to test at least the CFI instruction name to have some coverage. Other operands may be a bit redundant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112330/new/

https://reviews.llvm.org/D112330