[PATCH] D122939: [NVPTX][tests] Do not run the test CodeGen/Generic/2010-11-04-BigByval.ll

[Igor Chebykin via Phabricator via llvm-commits]

i-chebykin added a comment.

In D122939#3427269 <https://reviews.llvm.org/D122939#3427269>, @i-chebykin wrote:

> In D122939#3423407 <https://reviews.llvm.org/D122939#3423407>, @tra wrote:
>
>> Does it mean that the test will be disabled for everyone with NVPTX back-end compiled in?
>
> yes
>
>> That would not be the right thing to do, IMO.
>>
>> While I agree that this particular test does not add much to NVPTX testing, I think we still may want it to run.

I'm sorry, but after some verifying, I need to state that my answer `yes` is wrong.

1. The `UNSUPPORTED: nvptx` is applied to default target **//`only`//**
2. I have built two llvm builds: `Default target: x86_64-unknown-linux-gnu` and `Default target: nvptx64`. Then I ran the test with and without `-march=nvptx` and `UNSUPPORTED: nvptx|x86`. The following table shows the cases when the `UNSUPPORTED` is applied:

  	+---------------------------+--------------+--------------------+-------------------+
  	|      default target       | -march=<...> | UNSUPPORTED: <...> | Did the test run? |
  	+---------------------------+--------------+--------------------+-------------------+
  	|                           |              | nvptx              | run               |
  	|                           | N/A          +--------------------+-------------------+
  	|                           |              | x86                | NOT run           |
  	|                           +--------------+--------------------+-------------------+
  	|                           |              | nvptx              | run               |
  	|  x86_64-unknown-linux-gnu | nvptx        +--------------------+-------------------+
  	|                           |              | x86                | NOT run           |
  	|                           +--------------+--------------------+-------------------+
  	|                           |              | nvptx              | run               |
  	|                           | x86          +--------------------+-------------------+
  	|                           |              | x86                | NOT run           |
  	+---------------------------+--------------+--------------------+-------------------+
  	|                           |              | nvptx              | NOT run           |
  	|                           | N/A          +--------------------+-------------------+
  	|                           |              | x86                | run               |
  	|                           +--------------+--------------------+-------------------+
  	|                           |              | nvptx              | NOT run           |
  	| nvptx                     | nvptx        +--------------------+-------------------+
  	|                           |              | x86                | run               |
  	|                           +--------------+--------------------+-------------------+
  	|                           |              | nvptx              | NOT run           |
  	|                           | x86          +--------------------+-------------------+
  	|                           |              | x86                | run               |
  	+---------------------------+--------------+--------------------+-------------------+

So, it seems that using `UNSUPPORTED: nvptx` is OK.
Please review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122939/new/

https://reviews.llvm.org/D122939