[PATCH] D123522: [NVPTX][FIX] Allow __nvvm_reflect in the presence of opaque pointers
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 10:58:31 PDT 2022
nikic added inline comments.
================
Comment at: llvm/lib/Target/NVPTX/NVVMReflect.cpp:139
+ if (auto *CE = dyn_cast<ConstantExpr>(Str))
+ Str = CE->getOperand(0);
+ assert(isa<Constant>(Str) &&
----------------
Stripping an arbitrary constant expression looks a bit dubious -- shouldn't this be doing `Str->stripPointerCasts()`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123522/new/
https://reviews.llvm.org/D123522
More information about the llvm-commits
mailing list