[PATCH] D120781: [Bitcode] materialize Functions early when BlockAddress taken

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 10:50:13 PDT 2022


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM, with one nitpick inline!



================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:3398-3399
 
+    if (BlockAddress *BA = BlockAddress::lookup(&BB))
+      for (User *U : BA->users())
+        if (auto *I = dyn_cast<Instruction>(U)) {
----------------
Nit: IIRC, LLVM style usually adds `{}` braces to outer control structures whenever an inner one has them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120781/new/

https://reviews.llvm.org/D120781



More information about the llvm-commits mailing list