[PATCH] D123472: [SimplifyLibCalls] avoid slicing 64-bit integers in an ILP32 build (PR #54739)

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

In D123472#3441702 <https://reviews.llvm.org/D123472#3441702>, @xbolva00 wrote:

>> ILP32 test run shows a few crashes that appear unrelated to this change
>
> Is this even supported? I am wondering whether it is worth to fix it at all (and make code worse to read) if there are more crashes anyway.

It's one of those things where its not intentionally unsupported, but gets very little testing these days.  There's very little reason to run 32-bit LLVM on a 64-bit host, and most cross-compiles are going to be on 64-bit hosts.

In D123472#3442229 <https://reviews.llvm.org/D123472#3442229>, @nikic wrote:

> If we don't want to change the StringRef API, possibly add a common helper to this file?

Agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123472/new/

https://reviews.llvm.org/D123472