[PATCH] D123473: [LICM] Only create load in pre-header when promoting load.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 02:18:14 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2177
+  }
+  SSA.AddAvailableValue(Preheader, InitialValue);
 
----------------
Do we need to add the poison value here at all? If we don't add it, shouldn't SSAUpdater avoid creating the phi altogether and directly use the value stored in the loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123473/new/

https://reviews.llvm.org/D123473



More information about the llvm-commits mailing list