[PATCH] D123476: [MC][AVR] Implement decoding ST/LD

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 10 18:56:53 PDT 2022


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/Disassembler/AVRDisassembler.cpp:445
+    Result = decodeLoadStore(Instr, Insn, Address, this);
     if (Result != MCDisassembler::Fail)
       return Result;
----------------
The LD/ST instructions should be correctly decoded by the above `decodeInstruction`, unfortunately we have to explicitly use a specified DecoderFunction `decodeLoadStore`.

As I mentioned in https://reviews.llvm.org/D123442, we should re-think the organization of definition of LD/ST/LDD/STD in TD files to avoid that. But currently I can not figure out a proper way, it invloves register allocation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123476/new/

https://reviews.llvm.org/D123476



More information about the llvm-commits mailing list