[PATCH] D123433: [lld-macho][nfc] Use includeInSymtab for all symtab-skipping logic

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Nice!



================
Comment at: lld/MachO/ConcatOutputSection.cpp:332
+            thunkName, /*file=*/nullptr, thunkInfo.isec, /*value=*/0, thunkSize,
+            /*isWeakDef=*/false, /*isPrivateExtern=*/true,
             /*isThumb=*/false, /*isReferencedDynamically=*/false,
----------------
For the lines that are just reformatted without changes, maybe commit those in a separate commit.


================
Comment at: lld/MachO/SymbolTable.cpp:233
                                    bool referencedDynamically) {
-  assert(!isec || !isec->getFile()); // See makeSyntheticInputSection().
   Defined *s =
----------------
Doesn't this still make sense to explain the `/*file=*/nullptr` (instead of the `isec->getFile()` you'd expect -- or at least I expected that.)


================
Comment at: lld/MachO/SymbolTable.cpp:238
+                 referencedDynamically, /*noDeadStrip=*/false,
+                 /*isWeakDefCanBeHidden=*/false);
   s->includeInSymtab = includeInSymtab;
----------------
I think this one is just reformatted without any other changes too (ie maybe put in separate commit)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123433/new/

https://reviews.llvm.org/D123433