[PATCH] D123368: [X86] Remove different address space check in isNoopAddrSpaceCast
Wenju He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 10 17:03:18 PDT 2022
wenju added a comment.
isNoopPtrIntCastPair in lib/Transforms/Scalar/InferAddressSpaces.cpp calls isNoopAddrSpaceCast, but the two arguments might be the same. I notice isNoopAddrSpaceCast in other targets don't have such assert, so I remove this assert in X86 target.
Do you think we should check address spaces are not the same prior to isNoopAddrSpaceCast callsite in isNoopPtrIntCastPair?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123368/new/
https://reviews.llvm.org/D123368
More information about the llvm-commits
mailing list