[PATCH] D123041: [NVPTX] Avoid dots in global names

[Andrew Savonichev via Phabricator via llvm-commits]

asavonic added a comment.

In D123041#3427128 <https://reviews.llvm.org/D123041#3427128>, @tra wrote:

> Normally such replacement is done with `nvptx-assign-valid-global-names` pass, so we could pipe the tests through `opt -nvptx-assign-valid-global-names` which will ensure that tests don't have to know that dot is special for NVPTX. The downside is that it would have to be done for all llc tests. Perhaps we should consider moving the `nvptx-assign-valid-global-names` pass to the back-end.
>
> Not using dots only fixes the issues we have now and would still leave us open to test breaks if a new NVPTX-invalid name is added by accident. I think running `nvptx-assign-valid-global-names` in llc may be a better solution.

NVPTXAssignValidGlobalNames should already run in llc, but it can only rename globals with local linkage. Globals with external linkage are not renamed, and I'm not sure what is the rationale here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123041/new/

https://reviews.llvm.org/D123041