[PATCH] D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 10 13:56:34 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:210
   if (TT.isOSOpenBSD()) {
-    setLibcallName(RTLIB::STACKPROTECTOR_CHECK_FAIL, nullptr);
+    setLibcallName(RTLIB::STACKPROTECTOR_CHECK_FAIL);
   }
----------------
This is less readable. It’s not intuitive to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123467/new/

https://reviews.llvm.org/D123467



More information about the llvm-commits mailing list