[PATCH] D123451: [NFC] Rename `FixedLenDecoderEmitter` as `DecoderEmitter`

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 10 10:38:56 PDT 2022


myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM, please resolve the formatting issues though



================
Comment at: llvm/utils/TableGen/DisassemblerEmitter.cpp:130
+  //       variable length opcode, we might have to migrate webassembly to use
+  //       that.
   if (Target.getName() == "WebAssembly") {
----------------
0x59616e wrote:
> RKSimon wrote:
> > Raise a bug to track this?
> I change this TODO just for reflecting the status of this decoder emitter to avoid confusing someone.
> 
> Resolving this means we need to deploy our varlen encoding infra onto webassembly  backend. I don't know whether this is a good idea since this is a non-trivial work I guess.
I prefer creating a bug for this (and ping the wasm backend maintainer) but leave the comment unchanged


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123451/new/

https://reviews.llvm.org/D123451



More information about the llvm-commits mailing list