[PATCH] D123453: [InstCombine] Fold mul nuw+lshr exact to a single multiplication when the latter is a factor

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 9 10:46:32 PDT 2022


bcl5980 added a comment.

In D123453#3441118 <https://reviews.llvm.org/D123453#3441118>, @lebedev.ri wrote:

> In D123453#3441114 <https://reviews.llvm.org/D123453#3441114>, @bcl5980 wrote:
>
>> In D123453#3441088 <https://reviews.llvm.org/D123453#3441088>, @lebedev.ri wrote:
>>
>>> Please can you post the link to the general proof?
>>
>> I'm sorry but can you help to explain what the general proof is?
>
> The one you linked has hardcoded constants, yet the constants aren't hardcoded in the transform itself.

Thanks for the mentioning. I'll pay attention next time for constants.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123453/new/

https://reviews.llvm.org/D123453



More information about the llvm-commits mailing list