[PATCH] D123198: [LibCalls] Add argument extension attributes to more functions.

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 9 02:38:41 PDT 2022


xbolva00 added a comment.

In D123198#3440759 <https://reviews.llvm.org/D123198#3440759>, @xbolva00 wrote:

>>> Previously, the SExt attribute was always added to the i32 ldexp* argument as it was expected to be ignored by targets not needing it. This patch now changes this so that it is only added for the targets that need it in the first place.
>
> So required? required for correctness? Then is this right place to add them? With -O0, you will not get these attributes, no?

^


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123198/new/

https://reviews.llvm.org/D123198



More information about the llvm-commits mailing list