[PATCH] D123198: [LibCalls] Add argument extension attributes to more functions.

Sat Apr 9 02:32:22 PDT 2022

jonpa added inline comments.

================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:607
+    Changed |= setArgExtAttr(F, 1, TLI, false/*Signed*/);
+    Changed |= setArgExtAttr(F, 2, TLI, false/*Signed*/);
+    LLVM_FALLTHROUGH;
----------------
xbolva00 wrote:
> jonpa wrote:
> > efriedma wrote:
> > > Are uid_t/gid_t unsigned on all targets?
> > > 
> > > (I wouldn't mind just dropping LibFunc recognition for chown etc. if necessary...)
> > I see your point: since uid_t/gid_t (as far as I could see) are either unsigned or signed we cannot have a generic BuildLibCall utility for them with the current implementation.
> > 
> > If this is needed it seems to me we would need to add a target based flag similar to ShouldExtI32Param for this to properly determine the types of uid_t and gid_t.
> > 
> > All tests are however now passing after removing chown and lchown, so I did this instead now per your suggestion.
> > 
> Why do you need to drop it all? You added nothing so how this blocks you now?
It doesn't seem right to keep incorrect prototypes around if they are not fixed.

================
Comment at: llvm/test/Transforms/InferFunctionAttrs/annotate.ll:318
 declare i32 @chmod(i8*, i16 zeroext)

 ; CHECK: declare void @clearerr(%opaque* nocapture noundef) [[NOFREE_NOUNWIND]]
----------------
xbolva00 wrote:
> Do not remove test coverage.
see above

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123198/new/

https://reviews.llvm.org/D123198