[PATCH] D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter

[Ilia Diachkov via Phabricator via llvm-commits]

iliya-diyachkov marked 9 inline comments as done.
iliya-diyachkov added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVInstrInfo.cpp:155
+                                      int *BytesRemoved) const {
+  llvm_unreachable("Branch removal not supported, as MBB info not propagated "
+                   "to OpPhi instructions. Try using -O0 instead.");
----------------
MaskRay wrote:
> Can you verify this is unreachable? If it's unimplemented, you may call report_fatal_error
At the current stage we are not going to support branch optimization. But I admit that this may be implemented in the future, so let's change it to report_fatal_error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463