[PATCH] D116952: [ConstantFolding] Respect denormal handling mode attributes when folding instructions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 12:30:14 PDT 2022


efriedma added a comment.

Please add a testcase for opt -instsimplify.



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:612
+      case Instruction::FRem:
+        if (Q.CxtI != nullptr)
+          return ConstantFoldFPInstOperands(Opcode, CLHS, CRHS, Q.DL, Q.CxtI);
----------------
Maybe we should just return early if CxtI is null, instead of falling back to ConstantFoldBinaryOpOperands?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116952/new/

https://reviews.llvm.org/D116952



More information about the llvm-commits mailing list