[PATCH] D123411: lld/AMDGPU: Fix asserts if no object files are involved in link

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 11:24:39 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/test/ELF/amdgpu-elf-flags.s:5
 # RUN: ld.lld -shared %t-0.o %t-1.o -o %t.so
-# RUN: llvm-readobj --file-headers %t.so | FileCheck %s
+# RUN: llvm-readobj --file-headers %t.so | FileCheck -check-prefix=FIRSTLINK %s
 
----------------
arsenm wrote:
> MaskRay wrote:
> > Nit: for FileCheck options `--` is more common
> I don't think so. I'd guess across llvm about 10% use -- for check-prefix
```
% rg 'FileCheck.* -check' -l | wc -l
7261
% rg 'FileCheck.* --check' -l | wc -l
12039
```

In lld the ratio is even larger. Not needed to change now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123411/new/

https://reviews.llvm.org/D123411



More information about the llvm-commits mailing list