[PATCH] D123346: AMDGPU: Align the implicit kernel argument segment to 8 bytes for v5

Fri Apr 8 07:14:05 PDT 2022

cfang added a comment.

[AMD Official Use Only]

Hi, Matt:
Do you have any suggestion about the patch ? I need the permission to integrate.

Thanks
Changpeng

Get Outlook for iOShttps://aka.ms/o0ukef

________________________________

From: Brian Sumner via Phabricator <reviews at reviews.llvm.org>
Sent: Thursday, April 7, 2022 7:35:02 PM
To: Fang, Changpeng <Changpeng.Fang at amd.com>; Arsenault, Matthew <Matthew.Arsenault at amd.com>; Sumner, Brian <Brian.Sumner at amd.com>
Cc: Zhuravlyov, Konstantin <Konstantin.Zhuravlyov at amd.com>; jv356 at scarletmail.rutgers.edu <jv356 at scarletmail.rutgers.edu>; nhaehnle at gmail.com <nhaehnle at gmail.com>; Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; Stuttard, David <David.Stuttard at amd.com>; Tye, Tony <Tony.Tye at amd.com>; Kerbow, Austin <Austin.Kerbow at amd.com>; llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>; jay.foad at gmail.com <jay.foad at gmail.com>; wei.ding2 at amd.com <wei.ding2 at amd.com>; mahesha.comp at gmail.com <mahesha.comp at gmail.com>; acmerzhangxipeng at 163.com <acmerzhangxipeng at 163.com>; Kumar N, Bhuvanendra <Bhuvanendra.KumarN at amd.com>; wangyihansh at outlook.com <wangyihansh at outlook.com>; yanliang.mu at intel.com <yanliang.mu at intel.com>; aeubanks at google.com <aeubanks at google.com>; dougpuob at gmail.com <dougpuob at gmail.com>; michael.hliao at gmail.com <michael.hliao at gmail.com>; Neubauer, Sebastian <Sebastian.Neubauer at amd.com>; Song, Ruiling <Ruiling.Song at amd.com>; Saleil, Baptiste <Baptiste.Saleil at amd.com>; Lambert, Jacob <Jacob.Lambert at amd.com>
Subject: [PATCH] D123346 <https://reviews.llvm.org/D123346>: AMDGPU: Align the implicit kernel argument segment to 8 bytes for v5

[CAUTION: External Email]

b-sumner added a comment.

Looks fine to me!

CHANGES SINCE LAST ACTION

  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD123346%2Fnew%2F&data=04%7C01%7Cchangpeng.fang%40amd.com%7C9948ae9fa2004f0af0c008da190862bc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637849821660760975%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=HGOsFLQqbL4gLMC8SA4TXspkWjTbp%2FvLUyKG70XLfcw%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD123346&data=04%7C01%7Cchangpeng.fang%40amd.com%7C9948ae9fa2004f0af0c008da190862bc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637849821660760975%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=y6wYTWANYcU0mrWObqnuBceXzqkTLJp1E4m730ypy%2FU%3D&reserved=0

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123346/new/

https://reviews.llvm.org/D123346