[PATCH] D123014: [X86][FastISel] Remove with.overflow + select fold (PR54369)

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 04:08:20 PDT 2022


pengfei added a comment.

In D123014#3438645 <https://reviews.llvm.org/D123014#3438645>, @nikic wrote:

> In D123014#3438560 <https://reviews.llvm.org/D123014#3438560>, @pengfei wrote:
>
>> Does D122825 <https://reviews.llvm.org/D122825> still work if we don't have any constant operand? https://godbolt.org/z/5r6TvGxaP
>
> Yes: Constant expressions are still `Constant`, just not `ConstantInt`.

Got it. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123014/new/

https://reviews.llvm.org/D123014



More information about the llvm-commits mailing list