[PATCH] D123288: [LoopSink] Require MemorySSA

[Nikita Popov via Phabricator via llvm-commits]

nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1138
 bool llvm::canSinkOrHoistInst(Instruction &I, AAResults *AA, DominatorTree *DT,
-                              Loop *CurLoop, AliasSetTracker *CurAST,
-                              MemorySSAUpdater *MSSAU,
+                              Loop *CurLoop, MemorySSAUpdater *MSSAU,
                               bool TargetExecutesOncePerLoop,
----------------
fhahn wrote:
> I guess the APIs could also be updated to take `MSSAU`by reference, so we don't have to assert here.
I landed some follow-up conversion from pointers to references in https://github.com/llvm/llvm-project/commit/c8c63625601c04786cbf0819708725b830f0dfbb.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123288/new/

https://reviews.llvm.org/D123288