[PATCH] D116464: [SPIRV 5/6] Add LegalizerInfo, InstructionSelector and utilities

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVBaseInfo.cpp:380
+  switch (e) {
+  case ExecutionMode::Invocations:
+    return "Invocations";
----------------
Can we use X macros for the long list?


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVBaseInfo.cpp:486
+  switch (e) {
+  case StorageClass::UniformConstant:
+    return "UniformConstant";
----------------
Can we use X macros for the long list?


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVBaseInfo.cpp:556
+  switch (e) {
+  case SamplerAddressingMode::None:
+    return "None";
----------------
Can we use X macros for the long list?


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVBaseInfo.cpp:586
+  switch (e) {
+  case ImageFormat::Unknown:
+    return "Unknown";
----------------
Can we use X macros for the long list?


================
Comment at: llvm/lib/Target/SPIRV/SPIRVSubtarget.cpp:48
       FrameLowering(initSubtargetDependencies(CPU, FS)), TLInfo(TM, *this) {
-  CallLoweringInfo.reset(new SPIRVCallLowering(TLInfo));
+  GR.reset(new SPIRVGlobalRegistry(PointerSize));
+  CallLoweringInfo.reset(new SPIRVCallLowering(TLInfo, *this, GR.get()));
----------------
make_unique


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116464/new/

https://reviews.llvm.org/D116464