[PATCH] D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:52
+    unsigned i = 0;
+    for (const auto &Arg : F.args()) {
+      // Currently formal args should use single registers.
----------------
There is a Clang -Wunused-variable warning.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVSubtarget.cpp:46
+      FrameLowering(initSubtargetDependencies(CPU, FS)), TLInfo(TM, *this) {
+  CallLoweringInfo.reset(new SPIRVCallLowering(TLInfo));
+
----------------
make_unique


================
Comment at: llvm/lib/Target/SPIRV/SPIRVSubtarget.cpp:49
+  auto *RBI = new SPIRVRegisterBankInfo();
+  RegBankInfo.reset(RBI);
+}
----------------
RegBankInfo = std::make_unique<SPIRVRegisterBankInfo>();


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463