[PATCH] D112330: [AArch64] Async unwind - function epilogues

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Note: arm64-shrink-wrapping.ll and merge-store-dependency.ll need rebase.



================
Comment at: llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.cpp:130
 bool AArch64FunctionInfo::needsAsyncDwarfUnwindInfo() const {
-  if (!NeedsDwarfAsyncUnwindInfo.hasValue())
-    NeedsDwarfAsyncUnwindInfo =
-        needsDwarfUnwindInfo() &&
-        MF.getFunction().getUWTableKind() == UWTableKind::Async;
-  return NeedsDwarfAsyncUnwindInfo.getValue();
+  if (!NeedsAsyncDwarfUnwindInfo.hasValue()) {
+    const Function &F = MF.getFunction();
----------------
```
if (!NeedsAsyncDwarfUnwindInfo) {
  const Function &F = MF.getFunction();
  // TODO hasMinSize() is to ...
  NeedsAsyncDwarfUnwindInfo = 
}
return *NeedsAsyncDwarfUnwindInfo;
```

`operator*` is more common than getValue. The comment is too long to use the in-line style.


================
Comment at: llvm/test/CodeGen/AArch64/framelayout-sve.mir:266
 # CHECK-NEXT: $sp = frame-destroy ADDVL_XXI $sp, 3
+# CHECK-NEXT: frame-destroy CFI_INSTRUCTION
 # CHECK-NEXT: $sp = frame-destroy ADDXri $sp, 16, 0
----------------
Specify the operands of CFI_INSTRUCTION


================
Comment at: llvm/test/CodeGen/AArch64/framelayout-sve.mir:343
 # CHECK:      $sp = frame-destroy ADDXri $sp, 16, 0
+# CHECK-NEXT: frame-destroy CFI_INSTRUCTION
 # CHECK-NEXT: $sp, $fp, $lr = frame-destroy LDPXpost $sp, 2
----------------
Specify the operands of CFI_INSTRUCTION


================
Comment at: llvm/test/CodeGen/AArch64/framelayout-sve.mir:499
 # CHECK:      $sp = frame-destroy ADDVL_XXI $sp, 31
+# CHECK-NEXT: frame-destroy CFI_INSTRUCTION
 # CHECK-NEXT: $sp = frame-destroy ADDVL_XXI $sp, 31
----------------
Specify the operands of CFI_INSTRUCTION


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112330/new/

https://reviews.llvm.org/D112330