[PATCH] D122924: [lld] Add version info to generic driver output

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 21:41:21 PDT 2022


MaskRay added a comment.

In D122924#3431334 <https://reviews.llvm.org/D122924#3431334>, @kastiglione wrote:

> I don't agree that an #include and a function call "add complexity". By that reasoning, writing any code is adding complexity, and then the question is not whether code is complex (because it all would be), and only whether reviewers choose to evoke a "code complexity" argument. The llvm project has lots of complexity, and I don't believe this is an example of it.
>
> I appreciate you replying, and I won't take up any more time.

Then have you read my points about consistency and orthogonality?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122924/new/

https://reviews.llvm.org/D122924



More information about the llvm-commits mailing list