[PATCH] D122635: [RISCV] Filter out instructions which contain unsafe things when outlining

[Wang Pengcheng via Phabricator via llvm-commits]

pcwang-thead added a comment.

In D122635#3437559 <https://reviews.llvm.org/D122635#3437559>, @luismarques wrote:

> At first glance this seemed to make sense. The other targets also exclude these operand types, so I guess it really does :)
>
> PS: It's not clear to me what explains some of the remaining differences vs other targets. It would be good to, one of these days, look into harmonizing the accidental differences and documenting the justifiable ones.

I have taken a look at these differences, most of them are target-dependent and I think we don't need these.

we have tested outlining behaviors on llvm-test-suite, spec2006 and many other benchmarks, and haven't found any errors yet.

But I have no doubt that we may find some potential bugs in the future after enabling default outlining and larger code base's being compiled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122635/new/

https://reviews.llvm.org/D122635