[PATCH] D123172: Transforms: Fix code duplication between LowerAtomic and AtomicExpand

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

Good point on your response.

LGTM to this patch as a stepping stone.

I really do think it makes sense to cleanup the aarch64 usage given the new capability.  Would you mind doing that?  Not urgent, but it'd be good not to forget.

The others really seem like we need a function which lowers an inst to it's non-atomic form, and call it rather than invoking the pass as a helper.  Feel free to pursue that or not, we're at the point of diminishing returns here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123172/new/

https://reviews.llvm.org/D123172