[PATCH] D123326: [DAGCombiner] Stop invalid sign conversion in refineIndexType.

Thu Apr 7 17:30:47 PDT 2022

paulwalker-arm added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10456

-  if (refineIndexType(MSC, Index, MSC->isIndexScaled(), DAG)) {
     SDValue Ops[] = {Chain, StoreVal, Mask, BasePtr, Index, Scale};
----------------
paulwalker-arm wrote:
> Just wanted to say that I'd rather pass an `IndexType` directly here but I've resisted that because I have a follow-on patch that makes `ISD::IndexType` easier to work with and also removes `refineIndexType`'s `MSG` operand so I figured I'd keep this bug fix minimal.
D123347 is the aforementioned follow-on patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123326/new/

https://reviews.llvm.org/D123326