[PATCH] D123346: AMDGPU: Align the implicit kernel argument segment to 8 bytes for v5

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 17:04:55 PDT 2022


cfang created this revision.
cfang added reviewers: arsenm, b-sumner.
Herald added subscribers: hsmhsm, foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: All.
cfang requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

In emitting metadata for implicit kernel arguments, we need to be in sync with the actual loads
to align the implicit kernel argument segment to 8 byte boundary. In this work, we simply force
this alignment through the first implicit argument.
In addition, we don't emit metadata for any implicit kernel argument if none of them is actually used.


https://reviews.llvm.org/D123346

Files:
  llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp
  llvm/test/CodeGen/AMDGPU/hsa-metadata-queue-ptr-v5.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-reduced-hidden-args-v5.ll
  llvm/test/CodeGen/AMDGPU/implicit-kernel-argument-alignment.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123346.421367.patch
Type: text/x-patch
Size: 10170 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220408/8766c396/attachment.bin>


More information about the llvm-commits mailing list