[PATCH] D123288: [LoopSink] Require MemorySSA

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks!



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1138
 bool llvm::canSinkOrHoistInst(Instruction &I, AAResults *AA, DominatorTree *DT,
-                              Loop *CurLoop, AliasSetTracker *CurAST,
-                              MemorySSAUpdater *MSSAU,
+                              Loop *CurLoop, MemorySSAUpdater *MSSAU,
                               bool TargetExecutesOncePerLoop,
----------------
I guess the APIs could also be updated to take `MSSAU`by reference, so we don't have to assert here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123288/new/

https://reviews.llvm.org/D123288