[PATCH] D123333: [ARM] Add missing return to ARMTTIImpl::isLoweredToCall.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 12:30:35 PDT 2022


craig.topper created this revision.
craig.topper added reviewers: efriedma, samparker, dmgreen, SjoerdMeijer.
Herald added subscribers: StephenFan, hiraditya, kristof.beyls.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added a project: LLVM.

I assume we meant to return the result of the call to
BaseT::isLoweredToCall(F).

This might not be a functional change in practice because it would
still hit the default case in the switch and call
BaseT::isLoweredToCall(F) at the end.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123333

Files:
  llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp


Index: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
===================================================================
--- llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
+++ llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
@@ -1772,7 +1772,7 @@
 
 bool ARMTTIImpl::isLoweredToCall(const Function *F) {
   if (!F->isIntrinsic())
-    BaseT::isLoweredToCall(F);
+    return BaseT::isLoweredToCall(F);
 
   // Assume all Arm-specific intrinsics map to an instruction.
   if (F->getName().startswith("llvm.arm"))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123333.421313.patch
Type: text/x-patch
Size: 510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220407/5b6210c1/attachment.bin>


More information about the llvm-commits mailing list