[PATCH] D122986: [UpdateTestChecks] Add NVPTX support in update_llc_test_checks.py

Daniil Kovalev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 12:25:52 PDT 2022


kovdan01 marked an inline comment as done.
kovdan01 added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:493-497
+        try:
+          func_name_separator = m.group('func_name_separator')
+        except IndexError:
+          # Named match group 'func_name_separator' not found - use to default ':' sep.
+          func_name_separator = ':'
----------------
tra wrote:
> Existence of the named group can be checked directly:
> ```
> func_name_separator = m.group('func_name_separator')  if 'func_name_separator' in m.groupdict() else ":"
> ```
> 
> 
Thanks for useful advice! Fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122986/new/

https://reviews.llvm.org/D122986



More information about the llvm-commits mailing list