[PATCH] D122986: [UpdateTestChecks] Add NVPTX support in update_llc_test_checks.py

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 11:22:35 PDT 2022


tra added a comment.

LGTM, but I'll defer to UpdateTestChecks owners for the final approval.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:493-497
+        try:
+          func_name_separator = m.group('func_name_separator')
+        except IndexError:
+          # Named match group 'func_name_separator' not found - use to default ':' sep.
+          func_name_separator = ':'
----------------
Existence of the named group can be checked directly:
```
func_name_separator = m.group('func_name_separator')  if 'func_name_separator' in m.groupdict() else ":"
```




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122986/new/

https://reviews.llvm.org/D122986



More information about the llvm-commits mailing list