[PATCH] D123324: [VP] Explicitly map from VP intrinsic to ISD opcode

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 11:06:30 PDT 2022


rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.

Other than the nit above, this LGTM.

Thanks for the prompt fix and the cleanup @frasercrmck!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7325-7327
+#define HELPER_MAP_VPID_TO_VPSD(VPID, VPSD)                                       \
+  case Intrinsic::VPID:                                                        \
+    ResOPC = ISD::VPSD;                                                        \
----------------
Formatting is a bit odd here, `clang-format` usually vertically aligns the backslashes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123324/new/

https://reviews.llvm.org/D123324



More information about the llvm-commits mailing list