[PATCH] D123323: Adds diagnostics for missing opportunities of indirect call promotion.

[Rong Xu via Phabricator via llvm-commits]

xur added a comment.

Also, adding a test would be helpful.



================
Comment at: llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:373
+    }
+    uint64_t RemainingCount = TotalCount;
+    for (uint32_t I = 0; I < NumCandidates; I++) {
----------------
How about move this ilne to line 412 to ICallPromotionAnalysis? I think that's a better place for this.



================
Comment at: llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:380
+      ORE.emit([&]() {
+        OptimizationRemarkMissed R(DEBUG_TYPE, "NotEnoughCoverage", CB);
+        if (NumCandidates == MaxNumPromotions) {
----------------
How about NotMeetPercentThreshold. It's better to use a same terms for the whole message.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123323/new/

https://reviews.llvm.org/D123323