[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

The ScudoCUnitTest-mips64el-Test failure looks like a mips64el specific issue.

  FAILED: lib/scudo/standalone/tests/ScudoCUnitTest-mips64el-Test 
  cd /b/sanitizer-x86_64-linux-qemu/build/llvm_build2_debug_mips64el_qemu/lib/scudo/standalone/tests && /b/sanitizer-x86_64-linux-qemu/build/llvm_build0/bin/clang++ ScudoUnitTestsObjects.wrappers_c_test.cpp.mips64el.o ScudoUnitTestsObjects.scudo_unit_test_main.cpp.mips64el.o ScudoUnitTestsObjects.gtest-all.cc.mips64el.o /b/sanitizer-x86_64-linux-qemu/build/llvm_build2_debug_mips64el_qemu/lib/scudo/standalone/tests/libRTScudoCUnitTest.mips64el.a -o /b/sanitizer-x86_64-linux-qemu/build/llvm_build2_debug_mips64el_qemu/lib/scudo/standalone/tests/./ScudoCUnitTest-mips64el-Test -fuse-ld=lld --target=mips64el-linux-gnuabi64 -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -lstdc++ -pthread -latomic
  ld.lld: error: cannot preempt symbol: DW.ref.__gxx_personality_v0
  >>> defined in ScudoUnitTestsObjects.wrappers_c_test.cpp.mips64el.o
  >>> referenced by wrappers_c_test.cpp
  >>>               ScudoUnitTestsObjects.wrappers_c_test.cpp.mips64el.o:(.eh_frame+0x1420B)



In D120305#3436154 <https://reviews.llvm.org/D120305#3436154>, @thakis wrote:

> We're seeing the same problem here https://bugs.chromium.org/p/chromium/issues/detail?id=1314297&q=linux_upload_clang&can=2
>
> Reverted in e22a60b1c898a760a73417fa225c2fbe0609a69f <https://reviews.llvm.org/rGe22a60b1c898a760a73417fa225c2fbe0609a69f> for now.

This was a different problem: on some old systems glibc crt1.o was not compiled with -fPIC and cannot be linked as `-pie`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120305/new/

https://reviews.llvm.org/D120305