[PATCH] D123320: Adds diagnostics for missing opportunities of indirect call promotion.

[Hyoun Kyu Cho via Phabricator via llvm-commits]

netforce created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
netforce requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Some indirect branches that are important for performance might not
be promoted because there are too many targets and/or they don't have enough
counts to be promoted. Let's make them easier to understand by adding
diagnostics for such opportunities.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123320

Files:
  llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp


Index: llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
===================================================================
--- llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
+++ llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
@@ -391,8 +391,8 @@
           << "\% for a hot indirect call, and "
           << ore::NV("Candidates", ICallProfDataRef.size() - NumCandidates)
           << " candidates left with remaining count "
-          << ore::NV("RemainingCount", RemainingCount)
-          << " out of total count " << ore::NV("TotalCount", TotalCount) << " (";
+          << ore::NV("RemainingCount", RemainingCount) << " out of total count "
+          << ore::NV("TotalCount", TotalCount) << " (";
         for (uint32_t I = NumCandidates; I < ICallProfDataRef.size(); I++) {
           if (I != NumCandidates) {
             R << ", ";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123320.421253.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220407/ae40256e/attachment.bin>